[ff] Flag variant attachment #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see also flipt-io#188 |
|
Any issues with having to base64 encode/decode when interacting with the UI? How would this look on the client end of things? We'd have to decode it ourselves, correct? Would assuming it's always JSON improve that UX? |
|
@jalaziz, @amayvs is reaching out to the upstream to see what he opinion on the UI. |
* Extend flipt.proto to support attachment in variant * Extend DB with the new column * Extend UI to support the new field Co-authored-by: Kevin Ip <[email protected]>
kevin-ip
force-pushed
the
flag-variant-attachment
branch
from
85e878b to
c04ceb4
Compare
* add json format and limit valiation for attachment * update DB migration scripts * add attachment column to variant table
kevin-ip
changed the title
Co-authored-by: Mark Phelps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira: PTP-6049