Add BeamSpot. #363
Merged
Add BeamSpot. #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slava77
reviewed
Oct 7, 2021
| @@ -15,7 +15,7 @@ namespace StdSeq { | |||
| // Hit processing | |||
| //========================================================================= | |||
|
|
|||
| void LoadHits(Event &ev, EventOfHits &eoh) | |||
| void LoadHitsAndBeamSpot(Event &ev, EventOfHits &eoh) | |||
There was a problem hiding this comment.
CMSSW is not using this part; Cmssw_LoadHits_Begin is used.
perhaps a separate method that can pass the beamspot is easier; it will be used as LoadDeads
There was a problem hiding this comment.
Yes, cmssw will just call eoh.SetBeamSpot().
I thought it's cleaner to have a single method for standalone and rename it express intent.
|
I can imagine that the small test I did in trackreco/cmssw#54 is enough to confirm that this can be merged. Any objections? |
|
Yes, looks good ... mayeb Mario can push his addition to this branch as well? |
I think that we can easily decompose to separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check default values for sigma and beam-width.
Read/Write of BeamSpot for standalone bin files still needs to be implemented.