Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed region rebuilding, config cleanup #362

Merged
merged 7 commits into from
Sep 29, 2021
Merged

Seed region rebuilding, config cleanup #362

merged 7 commits into from
Sep 29, 2021

Conversation

osschar
Copy link
Collaborator

@osschar osschar commented Sep 28, 2021 •
edited
Loading

  • Implement seed region rebuilding.
    • Was tested on initialStep and detachedTriplet but there was no super improvement;
    • Config for these iterations is left in Geoms/CMS-2017.cc but commented out / inactive.
    • Logic for potential removal of seed-hits is in CombCandidate::CompactifyHitStorageForBestCand() and follows what is done in CMSSW: certain minumum number of hits is required to be available for backward-fit before (some) seed hits can be dropped. The number is int IterationConfig::m_backward_fit_min_hits. SteeringPArams::set_iterator_limits(..) has to be set accordingly -- to cover all possible seed-hit removal occurances.
  • Cleanup layer-plan setup - remove bools for pickup-only, backward-fit, backward-search: this logic has been moved to SteeringParams::iterator in a previous PR.
  • Add JSON schemas for SteeringParams and LayerControl. This makes saving of IterationConfig in JSON format almost complete -- the only missing part in seed-partition function.
  • Make ConfigJson_Load_File() really just load a JSON file over a default-instantiated IterationConfig. This allows CMSSW config-producer to just specify a JSON filename, without providing the default IterationsInfo.

MTV 1k ttbar 50, 7 iterations, baseline is PR 360 (named StopLoopers-2 in plots):
http://xrd-cache-1.t2.ucsd.edu/matevz/PKF/bks-det-trip-4.vs.stop-loopers-2/

There is no change in eff/fake-rate for built-tracks for all iterations (as there shouldn't be).

There is accompanying PR to trackreco/cmssw: trackreco/cmssw#50

@osschar
Backward search w/ dropping of seed hits for iterations 0 and 5.
4b9bb35
@osschar
- Cleanup layer_plan setup, copy comments from CMSSW code.
9c56779 
- Add JSON definitons for mkfit::LayerControl and mkfit::SteeringParams.

- Export also SteeringParams to JSON. Seed-partition lambda is the
  only thing not saved.
@osschar
Make ConfigJson_Load_File() really load the JSON.
1017870 
Rename to old version to ConfigJson_PatchLoad_File().
@osschar
Do CompactifyHitStorageForBestCand() in cmssw as well.
faf990e
@osschar
Consolidations for drop_seed_hits_in_bkw_search:
020e174 
- Add int IterationConfig::m_backward_fit_min_hits -- determines how
  many hits to take for backward fit, possibly using up some of the seed
  hits.

- Make hit selection before backward fit more like in CKF.
@osschar
Disable seed-reg-rebuild for detached triplet, retune ck-search picku…
2673177 
…p layers.
@osschar
Make ConfigJson_Load_File() really just load a JSON file over a defau…
dfd8177 
…lt-instantiated IterationConfig.

Restore all iteration defaults back to what they were before, ie, not backward search for initialStep or detachedTriplet.
@osschar osschar mentioned this pull request Sep 28, 2021
Merged
@mmasciov mmasciov merged commit cc601d2 into devel Sep 29, 2021
@osschar osschar deleted the bks-i0-i5 branch December 13, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osschar @mmasciov