PR #327 (solving existing conflicts) + dead modules option #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmasciov
force-pushed
the
deadModulesOption
branch
from
37dd49c to
5bd7363
Compare
This was referenced Jul 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Local merge of PR #327 (solving existing conflicts):
-> No visible change, as expected.
-> Very slight change, as expected (due to typo fix in cleaning parameters).
All other iterations, for both SIMVAL and SIMVALSEED: http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_pr327/
--> Will close PR #327 as this PR effectively replaces it.
(2) Add optionality for dead modules (in standalone mkFit):
-> As expected, when dead modules are used efficiency is lower, despite # hits/ track is higher:
http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_deadModulesOption/simvalseed_iter4/quality/?match=nHits*fit_pt0p0
All other iterations, for both SIMVAL and SIMVALSEED: http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_deadModulesOption/