-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid frtree to be written in plots.root + other updates for standalone workflow (samples and only initialStep for BH, STD and CE builds) #328
Conversation
808160a
to
67b4e17
Compare
The PR is ready for review/merge on my side. |
67b4e17
to
b39bbbc
Compare
…rks, or multi-iter ones
I noticed that validation-cmssw-benchmarks-multiiter.sh works only with forConf. |
This only reduces STD and BH, as well as the original CE, to initialStep, while we use MultiIter (an extension of CE) for multiple iterations. |
This PR is ready to be reviewed/merged. No additional change appears to be required in order to limit validation of builds other than multi-iter to initialStep-only, which is the goal of this PR, together with updating to latest samples and reduce size of validation output by avoiding un-necessary copies of trees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the files are now on phi3
val_scripts/validation-cmssw-10mu-fulldet-build-extrectracks.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this part https://github.com/trackreco/mkFit/pull/328/files/9d9a1beab800d77565f308f2f05e9c7b5008d1a7#diff-9bd117b4474e1261389e0f33d9f898dc985c780ab0e7c9c12339ce68867a0e66R125, which is already in MkBuilder. I also seemed to have problems with selection before relabeling here https://github.com/trackreco/mkFit/blob/devel/mkFit/MkBuilder.cc#L936-L937 if the order of our iterations is not the same as cmssw.
…ion in non-multi-iter val script
That part was aimed at reducing the size of the CMSSW valtree.
Hence, I reverted my change in the last commit, and just added "--num-iters-cmssw 1" in the non-multi-iter CMSSW validation script, for the CMSSW validation command. |
Brings size of plots.root down by ~300x.
Results are identical, e.g., can compare:
(1a) http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_pixelPairStep/simval_test_iter4/
(2a) http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_pixelPairStep/SAV_pixelPairStep/SAV_pixelPairStep_iter4/
or
(1b) http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_pixelPairStep/simval_test_iter22/
(2b) http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_pixelPairStep/SAV_pixelPairStep/SAV_pixelPairStep_iter22/
As for BH, STD and CE builds (not multi-iter), results are consistent after using only initialStep.
E.g., http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_pixelPairStep/SVA_noMultiIter_testV3/ to be compared to http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_pixelPairStep/SVA_multiIter/simvalseed_test_iter4/
Note (1): samples are latest available, including fix in PR #330.
Note (2): for non-multi-iter builds (BH, STD and CE), this limits validation to initialStep. Potential extension of BH and STD to multi-iter is not addressed in this PR.
Note (3): few of the scripts (not of common use anymore) still refer to SNB architecture, or are labeled as "SNB". As phi1 (SNB) is still online, this has not been changed in this PR.