Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking ntuple to bin file with seed based on curvilinear covariance #325

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

slava77
Copy link
Collaborator

@slava77 slava77 commented Jun 24, 2021

  • updated WriteMemoryFile.cc to read from tracking ntuple using curvilinear covariance
  • added 112X_10mu_MULTI for inputBin sample in val_scripts/validation-cmssw-benchmarks-multiiter.sh

I'm puzzled, however:

the puzzling part is that the efficiency does not agree with plots in #324 (comment)
Is the standalone validation fixing up the tracks in some way (and should we have enabled that way in CMSSW) ?

@slava77
Copy link
Collaborator Author

slava77 commented Jun 25, 2021

@osschar
as mentioned during the meeting, the file on phi3 is memoryFile.fv5.default.210623-b62fc88.bin as in val_scripts/validation-cmssw-benchmarks-multiiter.sh

From the comments during the meeting it sounds like the physics performance observed by me (in the PR description) is expected. So, this validates the .bin file conversion step (the main part of this PR).

please also check this PR and perhaps merge.

@osschar osschar merged commit fa8474f into trackreco:devel Jun 25, 2021
@osschar
Copy link
Collaborator

osschar commented Jun 25, 2021

thanks, will run the FPE catcher later today and see what comes up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants