Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixelPairStep addition #320

Merged
merged 4 commits into from
Jun 14, 2021
Merged

pixelPairStep addition #320

merged 4 commits into from
Jun 14, 2021

Conversation

mmasciov
Copy link
Collaborator

This is a draft PR for the addition of the pixelPairStep.
It has contributions by @leonardogiannini (who originally used highPtTripletStep windows for pixelPairStep).
I updated hit selection windows for pixelPairStep as for other iterations.

A comparison of the physics performance between the two sets of windows:
http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_mm/comparison_SIMVAL_iter6_hitselwindows/
-> Very slight difference in performance, with slightly more hits added in case of ad-hoc windows.

A comparison of the physics performance between the updated branch and CMSSW:
http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_mm/comparison_SIMVAL_iter6_hitselwindows_vsCMSSW/
-> Room for improvement for mkFit.

@mmasciov mmasciov marked this pull request as ready for review June 10, 2021 15:35
@osschar osschar merged commit 22f28c5 into devel Jun 14, 2021
@makortel
Copy link
Collaborator

I suppose the addition of pixelPairStep needs to be propagated to the CMSSW setup.

@mmasciov
Copy link
Collaborator Author

@makortel: this is correct.
I can work on the CMSSW propagation if you wish, and let you review it, unless you prefer of course to propagate it in first person.

@makortel
Copy link
Collaborator

@mmasciov Please do, thanks!

@osschar osschar deleted the pixelPairStepAddition branch June 21, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants