Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for the addition of the pixelPairStep.
It has contributions by @leonardogiannini (who originally used highPtTripletStep windows for pixelPairStep).
I updated hit selection windows for pixelPairStep as for other iterations.
A comparison of the physics performance between the two sets of windows:
http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_mm/comparison_SIMVAL_iter6_hitselwindows/
-> Very slight difference in performance, with slightly more hits added in case of ad-hoc windows.
A comparison of the physics performance between the updated branch and CMSSW:
http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_mm/comparison_SIMVAL_iter6_hitselwindows_vsCMSSW/
-> Room for improvement for mkFit.