Inactive modules #287
Merged
Inactive modules #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in the slides on December 4, I’ve implemented a temporary solution for the inactive modules in mkFit. The solution follows the first strategy that Giuseppe suggested in issue 256.
At this point I am not worried about how we know if a track passed through an inactive module; the only concern is what we do with that information once we have it. This implementation relies on the XWsrResult struct and adding a candidate with a -7 hit index (if a track passes through an inactive module) rather than a -1 hit index (what we use to indicate a missed hit or hole).
The baseline results (tested on 200 events) are here: https://areinsvo.web.cern.ch/areinsvo/MkFit/ChargeAssignment/April2020/inactiveModulesTempResults_baseline/
The results with these changes are shown here: https://areinsvo.web.cern.ch/areinsvo/MkFit/ChargeAssignment/April2020/inactiveModulesTempResults/
And for reference, I also ran validation for the case where maxCand is increased from 5 to 12: https://areinsvo.web.cern.ch/areinsvo/MkFit/ChargeAssignment/April2020/inactiveModulesTempResults_MaxCand12/
Significant changes will have to be introduced once the modifications to the hit vector are finished, but this is enough to tune physics performance in the context of Pandora's Box.