Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable backward search in pixelLessStep and tobTecStep #43

Merged

Conversation

leonardogiannini
Copy link

PR description:

modified json files and RecoTracker/MkFit/plugins/createPhase1TrackerGeometry.cc to accommodate backward search in PR 345 trackreco/mkFit#345

@leonardogiannini
Copy link
Author

I just realized I need to add a few extra lines and then validate again. I will do it very soon.

@leonardogiannini
Copy link
Author

the code should be ok
I also validated it here http://uaf-10.t2.ucsd.edu/~legianni/plots_bsearch_valid/ switching on only the pixelLess and tobTec iterations in mkFit.

Interestingly
http://uaf-10.t2.ucsd.edu/~legianni/plots_bsearch_valid/plots_building_pixelLessStep/hitsLayers.pdf
http://uaf-10.t2.ucsd.edu/~legianni/plots_bsearch_valid/plots_building_tobTecStep/hitsLayers.pdf

seem to be closer to CKF than the previous validation analogous plots here http://uaf-10.t2.ucsd.edu/~legianni/QCD-etc_testing/plots_2nd+3rd-att
(seems like the #holes cut is relaxed?)

anyway this should be ready for merging

@makortel makortel changed the title Integrate345 Enable backward search in pixelLessStep and tobTecStep Aug 24, 2021
@makortel
Copy link
Collaborator

Looks good by eye, I'll merge it after trackreco/mkFit#345 gets merged.

@mmasciov
Copy link

FYI: trackreco/mkFit#345 is good and just merged.

@makortel makortel merged commit 5e29902 into trackreco:CMSSW_11_2_0_mkFit_X Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants