Add dead modules code to MkFitEventOfHitsProducer #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makortel
reviewed
Jun 18, 2021
…b.com/cerati/cmssw into dead-modules-MkFitEventOfHitsProducer
|
Thanks, the rest looks ok to me (given the list of improvement ideas in #24). I'll merge after trackreco/mkFit#319 is merged (assuming no further conflicts). |
makortel
changed the title
makortel
changed the title
|
Following the merge of trackreco/mkFit#319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #24 , re-working the implementation in
MkFitEventOfHitsProducer. See the original PR for more details.