Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR for prototype final fit #154

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

leonardogiannini
Copy link

PR description:

The main changes are inside MkFinder.cc where the following functions are implemented

void fwdFitInputTracks(TrackVec &cands, std::vector<int> inds, int beg, int end);

void fwdFitFitTracks(const EventOfHits &eventofhits, const int N_proc, int nFoundHits, std::vector<std::vector<int>> indices_R2Z);`

void bkReFitInputTracks(TrackVec &cands, std::vector<int> inds, int beg, int end);

void bkReFitFitTracks(const EventOfHits &eventofhits, const int N_proc, int nFoundHits, std::vector<std::vector<int>> indices_R2Z);

void reFitOutputTracks(TrackVec &cands, std::vector<int> inds, int beg, int end, int nFoundHits, bool bkw = false);

std::vector<std::vector<int>> reFitIndices(const EventOfHits &eventofhits, const int N_proc, int nFoundHits);

A new function is added to KalmanUtilsMPlex

The function are wrapped inside MkBuilder and the call is made in RecoTracker/MkFitCMS/standalone/buildtestMPlex.cc (commented out for now)

} //end of fit func

//------------------------------------------------------------------------------

void MkFinder::bkFitPropTracksToPCA(const int N_proc) {
propagateTracksToPCAZ(N_proc, m_prop_config->pca_prop_pflags);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it practical to start splitting contributions to more than one file?
If we add smoothing and outlier rejection , it's probably another 1K lines if not more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants