Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes material p2r master #127

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cerati
Copy link
Collaborator

@cerati cerati commented May 24, 2023

PR description:

Fixes to propagation to R error propagation and to application of material effects (the latter from PR #106)

Note about math derivation:

https://www.overleaf.com/read/rkwnmmgpjzkc

PR validation:

ttbar: http://uaf-10.t2.ucsd.edu/~cerati/pr127_mod/

ttbar (using mkFit for low pt iterations): http://uaf-10.t2.ucsd.edu/~cerati/pr127_lowpt_mod/

mu pt<1 using mkFit only for LowPtQuadStep: http://uaf-10.t2.ucsd.edu/~cerati/pr127_mu_lqonly_mod/

The configuration named mod is the same as this PR but with the following lines commented out: https://github.com/cerati/cmssw/blob/fixes-material-p2r-master/RecoTracker/MkFitCore/src/PropagationMPlex.icc#L171-L175
It looks like mod gives the best results, so somehow the lines above are problematic for some reason.

@leonardogiannini
Copy link

  1. PR127 (after introducing material changes) http://uaf-10.t2.ucsd.edu/~legianni/plots_compare_127_andMod - should cross check with http://uaf-10.t2.ucsd.edu/~cerati/pr127_mod/
  2. checking new windows before 127 (to validate the method) http://uaf-10.t2.ucsd.edu/~legianni/plots_newWindows_0 - (this is also an errata courage wrt to what was shown in the previous internal meeting) - not fully consistent especially in the detached iterations
  3. http://uaf-10.t2.ucsd.edu/~legianni/plots_compare_127_newWindows/ - new windows derived with PR 127 but not with the "mod" version. Overall increase in fake rates and small eff. loss - need to repeat in the mod version

@slava77
Copy link

slava77 commented Jun 14, 2023

http://uaf-10.t2.ucsd.edu/~legianni/plots_compare_127_newWindows/ - new windows derived with PR 127 but not with the "mod" version. Overall increase in fake rates and small eff. loss - need to repeat in the mod version

Thank you for the MTV plots.
We have a pretty large drop in the 0.4 - 0.8 GeV range.
It would be good to get a variant of MTV plots with efficiency plots selected to be below 0.9 GeV to understand the situation better.

Is "original-127" using the old windows from Mario, or is it rederived?
It would be good to compare cases based on the same machinery to decouple the changes in the parameterization/fitting strategy of the windows.
Do you know roughly how the windows change especially in lower pt bins e.g. in the initialStep iteration?
Naively, the dphi/dq windows should not really change, and the chi2 would change. Is that the case?

From the dist plots it looks like the losses are mainly in 0.5 < |eta| < 1.5, but are still significant in the barrel as well. There is something interesting in one bin near eta of 2.5; perhaps some feature in the window selection in the edge of the acceptance?

@leonardogiannini
Copy link

This is no longer compatible with master (after the update of the material derivation). We should remember before integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants