-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes material p2r master #127
base: master
Are you sure you want to change the base?
Conversation
|
Thank you for the MTV plots. Is "original-127" using the old windows from Mario, or is it rederived? From the dist plots it looks like the losses are mainly in 0.5 < |eta| < 1.5, but are still significant in the barrel as well. There is something interesting in one bin near eta of 2.5; perhaps some feature in the window selection in the edge of the acceptance? |
This is no longer compatible with master (after the update of the material derivation). We should remember before integration |
PR description:
Fixes to propagation to R error propagation and to application of material effects (the latter from PR #106)
Note about math derivation:
https://www.overleaf.com/read/rkwnmmgpjzkc
PR validation:
ttbar: http://uaf-10.t2.ucsd.edu/~cerati/pr127_mod/
ttbar (using mkFit for low pt iterations): http://uaf-10.t2.ucsd.edu/~cerati/pr127_lowpt_mod/
mu pt<1 using mkFit only for LowPtQuadStep: http://uaf-10.t2.ucsd.edu/~cerati/pr127_mu_lqonly_mod/
The configuration named
mod
is the same as this PR but with the following lines commented out: https://github.com/cerati/cmssw/blob/fixes-material-p2r-master/RecoTracker/MkFitCore/src/PropagationMPlex.icc#L171-L175It looks like
mod
gives the best results, so somehow the lines above are problematic for some reason.