remove MkFit clang16 vectorization warnings #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slava77
reviewed
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Removes the "loop not vectorized" warnings in cms-sw#41624. Four of the loops are not vectorized by any of our compilers, so I commented out the simd pragma for those. For the others that are vectorized by icc, I added an ifdef to disable the simd pragma for clang. I would have preferred to suppress the warning messages with a compiler pragma, but that doesn't seem to be possible for the case where vectorization is supposed to be forced.
PR validation:
Compiles without warnings with clang16 and gcc.