Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix initialization of local variables in propagation to avoid vagrind warnings #110

Merged

Conversation

dan131riley
Copy link
Collaborator

PR description:

This PR fixes the initialization of a couple of MPlex arrays allocated on the stack. Previously they were being initialized up to N_proc, but many of the propagation loops go up to NN to aid vectorization. This PR ensures that any MPlex entries past N_proc are set to zero.

PR validation:

Reran valgrind and verified that there were no MkFit warnings.

@slava77
Copy link

slava77 commented Nov 11, 2022

@dan131riley
the changes look good to me.
Considering the holiday today, I propose to wait til Monday PM in case of comments and then submit to cms-sw

@osschar
Copy link
Collaborator

osschar commented Nov 14, 2022

Thanks Dan! Yes, let's push it over to cmssw :)

@dan131riley
Copy link
Collaborator Author

What's the preferred way to push to cmssw--merge here and make the PR from trackreco, and make the PR from my repo?

@slava77
Copy link

slava77 commented Nov 17, 2022

What's the preferred way to push to cmssw--merge here and make the PR from trackreco, and make the PR from my repo?

the master fork in trackreco/cmssw is not meant for direct merging, only as a reference for preliminary PR reviews.
Please submit the branch used here to cms-sw/cmssw.

@dan131riley
Copy link
Collaborator Author

Submitted as cms-sw#40105

@slava77
Copy link

slava77 commented Nov 17, 2022

oh, and no need to close here. After the upstream is merged it becomes clear that this one is merged as well (once the master here is synced up).

@slava77 slava77 reopened this Nov 17, 2022
@slava77 slava77 merged commit 3f2a385 into trackreco:master Nov 21, 2022
@dan131riley dan131riley deleted the PropagationMPlex-valgrind-fixes branch January 10, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants