Backport: Introduce flag for length access after push/unshift #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug Simply doing a `.push()` or `.unshift()` call after creating the Array during construction of a component is enough to trigger the issue. This will be red in CI; the follow-on commit will fix it. (cherry picked from commit bd984e6)
For these methods, `Array` itself immediately gets the `.length` to return after invoking them. Thus, if we are reading `.length`, it may be a normal user-triggered read, or it may be a read triggered by Array itself. In the latter case, it is because we have just done `.push()` or `.unshift()`; in that case it is safe *not* to treat reading `.length` as a *read* operation, since calling `.push()` or `.unshift()` cannot otherwise be part of a "read" operation safely, and if done during an *existing* read (e.g. if the user has already checked `.length` *prior* to this), that will still trigger the assertion. Accordingly, set the new flag to `true` when calling `.push()` or `.unshift()`, and then clear it during the immediately-following `.length` check. (cherry picked from commit 7621b04)
chriskrycho
force-pushed
the
backport-bugfix
branch
from
8f2d4fd to
ea77bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #397 for a 3.1.1 release. There are some (known) bugs with lazy engines and ember-auto-import which make pulling in a v2 addon difficult in some cases. This should unblock that.