Switch to using @tsconfig/ember
#336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add the dependency to both the addon and the test-app - update the test app to use indexed access
test-app/tsconfig.json
Outdated
| ] | ||
| "test-app/tests/*": ["tests/*"], | ||
| "test-app/*": ["app/*"], | ||
| "tracked-built-ins": ["../addon/addon"], |
There was a problem hiding this comment.
side-note: I need to check if these mappings for tracked-built-ins is actually needed. TS should just be happy in test-app as tracked-built-ins is now injected like regular npm package and has all the types in it.
There was a problem hiding this comment.
Ah, yep, we should be able to remove this.
SergeAstapov
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #335