Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): improve package name detection for metadata #2607

Merged
merged 4 commits into from
Feb 5, 2025
Merged

fix(sdk): improve package name detection for metadata #2607

merged 4 commits into from
Feb 5, 2025

Conversation

doronkopit5
Copy link
Contributor

@doronkopit5 doronkopit5 commented Feb 5, 2025 •
edited
Loading

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@doronkopit5 doronkopit5 marked this pull request as ready for review February 5, 2025 14:39
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 5, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 5, 2025
@doronkopit5 doronkopit5 merged commit 8c9ef5a into main Feb 5, 2025
9 checks passed
@doronkopit5 doronkopit5 deleted the dk/fix_dist_error_on_python_3_12 branch February 5, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doronkopit5 @nirga