Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openai): don't eagerly import types from openai as they may not be available #2601

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

nirga
Copy link
Member

@nirga nirga commented Feb 4, 2025

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Feb 4, 2025
@nirga nirga changed the title fix(openai): don't eagerly import types from openai as they may not b… fix(openai): don't eagerly import types from openai as they may not be available Feb 4, 2025
@nirga nirga merged commit 09a9d04 into main Feb 4, 2025
9 checks passed
@nirga nirga deleted the fix-openai-v0-compat branch February 4, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants