Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(together): add response id attribute #2551

Merged
merged 2 commits into from
Jan 26, 2025
Merged

fix(together): add response id attribute #2551

merged 2 commits into from
Jan 26, 2025

Conversation

dinmukhamedm
Copy link
Contributor

@dinmukhamedm dinmukhamedm commented Jan 25, 2025 •
edited
Loading

Partially addresses #2236

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. python Pull requests that update Python code testing labels Jan 25, 2025
@dinmukhamedm dinmukhamedm mentioned this pull request Jan 25, 2025
Open
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 26, 2025
@nirga nirga merged commit 61a8cda into traceloop:main Jan 26, 2025
9 checks passed
@nirga nirga deleted the response-id/together branch January 26, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dinmukhamedm @nirga