Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(langchain): address warning for NoneType attibute; update some test deps #2539

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix(langchain): address warning for NoneType attibute; update some test deps #2539

merged 1 commit into from
Jan 22, 2025

Conversation

dinmukhamedm
Copy link
Contributor

@dinmukhamedm dinmukhamedm commented Jan 22, 2025 •
edited by nirga
Loading

Fixes #2537

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. python Pull requests that update Python code testing labels Jan 22, 2025
nirga
nirga approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks so much @dinmukhamedm!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2025
@nirga nirga merged commit f5d95b4 into traceloop:main Jan 22, 2025
9 checks passed
@nirga nirga deleted the fix/langchain-none-type branch January 22, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Invalid type NoneType for attribute 'traceloop.association.properties.ls_temperature' value.
2 participants
@dinmukhamedm @nirga