Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gemini): set prompt attributes for role and content #2511

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix(gemini): set prompt attributes for role and content #2511

merged 1 commit into from
Jan 15, 2025

Conversation

dinmukhamedm
Copy link
Contributor

Addressing #2419

  • I have added tests that cover my changes. <-- Yes, but they are not reproducible without my gemini key
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. python Pull requests that update Python code testing labels Jan 13, 2025
dinmukhamedm
dinmukhamedm commented Jan 13, 2025
View reviewed changes
packages/opentelemetry-instrumentation-google-generativeai/tests/test_generate_content.py
Comment on lines +8 to +10
# This test is working, but since Gemini uses gRPC,
# vcr does not record it, therefore we cannot test this without
# setting the API key in a shared secret store like GitHub secrets
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirga any suggestions on how to go about this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately no :/ only to mock responses

@dinmukhamedm dinmukhamedm changed the title fix(gemini) set prompt attributes for role and content fix(gemini): set prompt attributes for role and content Jan 14, 2025
nirga
nirga approved these changes Jan 15, 2025
View reviewed changes
packages/opentelemetry-instrumentation-google-generativeai/tests/test_generate_content.py
Comment on lines +8 to +10
# This test is working, but since Gemini uses gRPC,
# vcr does not record it, therefore we cannot test this without
# setting the API key in a shared secret store like GitHub secrets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately no :/ only to mock responses

@nirga nirga merged commit 92901ee into traceloop:main Jan 15, 2025
9 checks passed
@nirga nirga deleted the fix/gemini-attributes branch January 15, 2025 04:04
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dinmukhamedm @nirga