Structured output for openai #1996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the refusal state. Created a unitTest.py file for testing and app.log file for checking the log is successfully saved or not.
…strumentation/openai/testlog.py
dosubot
bot
added
size:M
nirga
reviewed
Sep 19, 2024
There was a problem hiding this comment.
hey @AnsariZayd thanks but we should try to stay as close as we can to the current code. Left some comments :)
| @@ -88,6 +88,10 @@ def wrapper(wrapped, instance, args, kwargs): | |||
| args, | |||
| kwargs, | |||
| ) | |||
| span = tracer.start_span(name="openai.response") | |||
There was a problem hiding this comment.
this should be on the original span and not on a new one
| from utils import handle_structured_output # Ensure this import is correct | ||
|
|
||
| # Configure logging to write to a file | ||
| logging.basicConfig( |
|
|
||
| logging.info("Logging configuration set up.") | ||
|
|
||
| class TestHandleStructuredOutput(unittest.TestCase): |
There was a problem hiding this comment.
this is not pytest - please take a look at existing tests and extend
|
Fixed with #2111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the testenv file and now using pytest.