upgrade to [email protected] #3953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps node from 16.17.0-alpine to 20.2.0-alpine. --- updated-dependencies: - dependency-name: node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.18.19 to 20.2.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3953 +/- ##
=======================================
Coverage 86.34% 86.34%
=======================================
Files 66 66
Lines 4709 4709
Branches 563 563
=======================================
Hits 4066 4066
Misses 637 637
Partials 6 6
☔ View full report in Codecov by Sentry. |
|
verbatimModuleSyntaxを対応させるためにtsのバージョンを4->5にあげたらtype-checkが大量にwarn吐いたので一旦verbatimModuleSyntaxの設定は消しました |
ras0q
commented
May 23, 2023
| @@ -0,0 +1 @@ | |||
| engine-strict=true | |||
There was a problem hiding this comment.
package.jsonのenginesに書いたバージョンを厳守するやつです
https://docs.npmjs.com/cli/v8/using-npm/config#engine-strict
This reverts commit d2963d5.
ras0q
commented
May 24, 2023
Comment on lines
-17
to
+18
| "importsNotUsedAsValues": "error", | ||
| // TODO: TypeScriptをv5にしたら使う | ||
| // "verbatimModuleSyntax": true, |
There was a problem hiding this comment.
別PRでtypescript5.0にあげるつもりです
https://www.typescriptlang.org/tsconfig#importsNotUsedAsValues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verbatimModuleSyntax, deprecateimportsNotUsedAsValuesandpreserveValueImportsmicrosoft/TypeScript#52203