drm/imx: lcdifv3: Fix videomode settings

Do not silently assume the opposite bus flag if one condition is invalid. There are dedicated bus flags and videomode flags for either active high or active low. Do explicitly check for them. Signed-off-by: Alexander Stein <[email protected]>
tq-steina · Jul 11, 2024 · 7a31ed7 · 7a31ed7
1 parent ee366aa
commit 7a31ed7
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/drivers/gpu/drm/imx/lcdifv3/lcdifv3-crtc.c b/drivers/gpu/drm/imx/lcdifv3/lcdifv3-crtc.c
@@ -159,12 +159,14 @@ static void lcdifv3_crtc_atomic_enable(struct drm_crtc *crtc,
 
 	if (imx_crtc_state->bus_flags & DRM_BUS_FLAG_DE_HIGH)
 		vm.flags |= DISPLAY_FLAGS_DE_HIGH;
-	else
+	if (imx_crtc_state->bus_flags & DRM_BUS_FLAG_DE_LOW)
 		vm.flags |= DISPLAY_FLAGS_DE_LOW;
 
-	if (imx_crtc_state->bus_flags & DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE)
+	if ((imx_crtc_state->bus_flags & DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE) ||
+	    (imx_crtc_state->bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE))
 		vm.flags |= DISPLAY_FLAGS_PIXDATA_POSEDGE;
-	else
+	if ((imx_crtc_state->bus_flags & DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE) ||
+	    (imx_crtc_state->bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE))
 		vm.flags |= DISPLAY_FLAGS_PIXDATA_NEGEDGE;
 
 	pm_runtime_get_sync(lcdifv3_crtc->dev->parent);