Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly implement CancellationToken to prevent downloads hanging #349

Closed
tpill90 opened this issue Jan 27, 2024 · 1 comment
Closed

Correctly implement CancellationToken to prevent downloads hanging #349

tpill90 opened this issue Jan 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tpill90
Copy link
Owner

tpill90 commented Jan 27, 2024 •
edited
Loading

This has been a long standing bug where some users will have their downloads hang without ever completing. This is due to an improper handling of CancellationToken combined with how WebClient timeouts are handled.

Some examples where this is likely the cause:

issues/331
issues/318
@tpill90 tpill90 added the bug Something isn't working label Jan 27, 2024
This was referenced Jan 27, 2024
Closed
Closed
@tpill90 tpill90 added the pending release Fix has been merged, needs to be published label Jan 27, 2024
tpill90 added a commit that referenced this issue Jan 27, 2024
@tpill90
Merge pull request #350 from /issues/349-CancellationToken
11752e8
@tpill90 tpill90 removed the pending release Fix has been merged, needs to be published label Feb 3, 2024
@tpill90
Copy link
Owner Author

tpill90 commented Feb 3, 2024

Released in v2.4.0

@tpill90 tpill90 closed this as completed Feb 3, 2024
@tpill90 tpill90 mentioned this issue Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpill90