Skip to content

Commit

Permalink
Fixing an issue where the git commit hash was being appended to the a…
Browse files Browse the repository at this point in the history
…pplication's version number when publishing. This was caused by a change in the .net sdk itself starting with .net 8
  • Loading branch information
tpill90 committed Dec 6, 2023
1 parent 5afde43 commit 9e4dde7
Showing 1 changed file with 16 additions and 12 deletions.
28 changes: 16 additions & 12 deletions SteamPrefill/SteamPrefill.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,27 @@

<!-- Publish Settings -->
<PropertyGroup>
<PublishTrimmed>true</PublishTrimmed>
<PublishTrimmed>true</PublishTrimmed>
<EnableTrimAnalyzer>true</EnableTrimAnalyzer>
<TrimmerSingleWarn>false</TrimmerSingleWarn>
<!-- Reverts back to the default trim mode used by dotnet 6, otherwise CliFx breaks without reflection -->
<TrimMode>partial</TrimMode>
<TrimMode>partial</TrimMode>

<PublishReadyToRun>true</PublishReadyToRun>
<PublishSingleFile>true</PublishSingleFile>

<EnableTrimAnalyzer>true</EnableTrimAnalyzer>
<TrimmerSingleWarn>false</TrimmerSingleWarn>
<!-- Required to be enabled in order to run this application on Ubuntu Docker images. -->
<InvariantGlobalization>true</InvariantGlobalization>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<DebugType>none</DebugType>
<DebugSymbols>false</DebugSymbols>
</PropertyGroup>

<InvariantGlobalization>true</InvariantGlobalization>

<!-- Removes the git commit hash being appended to the version number when publishing.. Ex: v2.3.0+5afde434cfe8472ba36138c4912e7aa08a7a22d0 -->
<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
<DebugType>none</DebugType>
<DebugSymbols>false</DebugSymbols>
</PropertyGroup>

<!--TODO add this to the other projects-->
<PropertyGroup>
<!-- Removes the full file system path from exception stack traces, only shows the file names now -->
Expand Down

0 comments on commit 9e4dde7

Please sign in to comment.