Replaced deprecated method Poly_Triangulation Triangles()

[rsm-gh]

Replaced deprecated method Poly_Triangulation Triangles() with Triangle()

Summary by Sourcery

Enhancements:

• Replace deprecated method Poly_Triangulation::Triangles() with Triangle() to ensure compatibility with updated API.

[sourcery-ai]

Reviewer's Guide by Sourcery

The PR updates the triangle retrieval method in the shape tessellation code by replacing the deprecated Triangles() method with the newer Triangle() method. The change maintains the same functionality while using the updated API.

Class diagram for ShapeTesselator changes

classDiagram
    class ShapeTesselator {
        +void Tesselate(bool compute_edges, float mesh_quality, bool parallel)
    }
    class Poly_Triangulation {
        +Standard_Integer NbTriangles()
        +void Triangle(Standard_Integer nt)
    }
    ShapeTesselator --> Poly_Triangulation : uses
    note for Poly_Triangulation "Replaced deprecated Triangles() with Triangle()"

Loading

File-Level Changes

Change	Details	Files
Updated triangle retrieval method in tessellation implementation	Replaced deprecated Poly_Array1OfTriangle Triangles() with direct Triangle() method calls Changed triangle array size calculation to use NbTriangles() directly Updated triangle vertex retrieval to use Triangle(nt) instead of triangles(nt)	src/Tesselator/ShapeTesselator.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rsm-gh - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[tpaviot]

@rsm-gh good catch! Deprecation warnings are not raised on my machine, there's something I must have forgot to check/uncheck some option in cmake.

The ShapeTesselator code is quite old, it works but I guess it could benefit from a general cleanup. Please feel free to report any improvement.

[rsm-gh]

Hello @tpaviot ,

I actually stopped using the Python CAD-Backend in my production server and replaced it by C++, so I can push some code clean up and minor improvements, I just need to check if they are all C++ 11 compatible.

Also I'm investigating some crashes that are coming from the ShapeTesselator & the STEP CAF Reader, so I'll probably push some more useful contributions in the future :)