Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation instructions after 83687c4 #1351

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Andrej730
Copy link
Contributor

@Andrej730 Andrej730 commented Jul 12, 2024

Since PYTHONOCC_BUILD_TYPE is deprecated.

Summary by Sourcery

This pull request updates the installation documentation to replace the deprecated PYTHONOCC_BUILD_TYPE with CMAKE_BUILD_TYPE in the build configuration instructions.

  • Documentation:
    • Updated installation instructions to replace deprecated PYTHONOCC_BUILD_TYPE with CMAKE_BUILD_TYPE.

Copy link

sourcery-ai bot commented Jul 12, 2024

Reviewer's Guide by Sourcery

This pull request updates the installation instructions in the INSTALL.md file to replace the deprecated PYTHONOCC_BUILD_TYPE with CMAKE_BUILD_TYPE.

File-Level Changes

Files Changes
INSTALL.md Updated the build type configuration in the installation instructions to use CMAKE_BUILD_TYPE instead of the deprecated PYTHONOCC_BUILD_TYPE.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Andrej730 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Andrej730
Copy link
Contributor Author

@tpaviot

@tpaviot
Copy link
Owner

tpaviot commented Jul 22, 2024

👍

@tpaviot tpaviot merged commit 118942c into tpaviot:master Jul 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants