Review/fix msvc warnings

[QbProg]

Completed "first pass" of warning fixes, probably enough for 0.4, of the MSVC compiler (/W4)

Some warnings remain:

• 64 bit warnings , as mostly related to 32-bit standard array access. Hopefully in the future the array size will match the architecture, at least where required
• Breaking changes warnings : some warnings are not removed since they require a breaking change to be correctly fixed. Postponed to 0.5

Also , a bug was fixed but to insufficient array size.

I've marked some @todo here and there to mark critical points

[tpaviot]

I still have to remove a few xcode warnings. I will work from your branch when it is merged to master.

[tpaviot]

compiles under MacOSX.

+1

[dbarbier]

Hello, I am not sure that changes in CGM_Driver.cxx are fine with Borland compiler, IIRC patches had been committed to avoid trigraphs in function arguments. I believe that swapping assignments would work (ditto for int_style):

-    curatt.edge_vis = myEdgeVisibility = (DrawEdge ? ON : OFF);
+    myEdgeVisibility = curatt.edge_vis = (DrawEdge ? ON : OFF);

Anyway +1 for this branch, with or without this change.

[IvaKom]

Hello, MSVS 2008 complains about using uninitialized pBuff variable at runtime. OSD/OSD_Environment.cxx, line 261. I fixed it with assigning a zero string ("") to it, works well.
Upd: initializing it with NULL (line 254) works as well.

[QbProg]

Thank you for the catch!
Strange that the compiler didn't complain at compile time, even with W4!

I'm fixing this in this branch, plus the other modification, and then
I will merge.
I will assign NULL instead of ""

Qb

2011/6/22 IvaKom
[email protected]:

Hello, MSVS 2008 complains about using uninitialized pBuff variable at runtime. OSD/OSD_Environment.cxx, line 261. I fixed it with assigning a zero string ("") to it, works well.

Reply to this email directly or view it on GitHub:
#44 (comment)