-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review/all warning fixes #41
Conversation
Removed unused-local-var identified with XCode/gcc 4.2.1 Removed lines do not contain method calls (or call methods which are known to have no side effect, like Abs), these changes should thus be safe. Fixes deal with all Toolkits as well as DRAW.
Removed PArrayPrint and PArrayInquire declared static but never defined in OpenGl_PrimitiveArray.cxx
Removed unused functions raising defined but not used warning
Fixed warning Label 'ERR' defined but not used
Fixed format %d expects type int but argument XX is long unsigned int
Fix warning 'myVar' *may* be used uninitialized in this function
Fix warning 'myVar' *is* used uninitialized in this function
Removed unused-local-var identified with XCode/gcc 4.2.1. Lines removed call methods which may have side effects, so this commit must be double-checked. Fixes deal with all Toolkits as well as DRAW. (QbProg : included only commits without side effects )
Fixed comparison between signed and unsigned int warnings (QbProg: changed some modifications to be done in 0.5)
Fixed warning: deprecated conversion from string constant to 'char*'
Removed unuinitialized vars from TKIGES
Removed old-style C declarators from TKIges
Fixes (and todos) in TKStepBase
Fixes many potential uninitialized vars around Draw and Test
Fixed various cast warnings
Fixed some assignments in conditional expressions
Unused local var
Fixed some unreachable code warnings
This includes a buffer overflow in Interface_MSG
Removed unused function (WNT)
Fixed many potentially un-init vars
Removed unreachable code warnings, and marked with @todo when in doubt
Small one for now. In target-0.5 the function should return char instead of Standard_Integer
Also fixed a bug in TrimShellCorner due to a missing ==
+1 |
+1 My only concern is that there are 4 commits modifying IntCurve_IntConicConic_Tool.cxx, but
So it would be better to rewrite this branch again to avoid do/undo commits, but if you do not know how to do that, I won't oppose this merge, it is better to have this branch merged as soon as possible. |
Sorry, that's my fault, the correction took 3 commits instead of 1 due I imagine how to rewrite it (rebase -i I guess :), but will not have |
As I wrote in my previous comment, no problem for me, and when you have time, take a few minutes to learn to use |
This includes:
I've reviewed again the changes, and there should not be evident problems nor breaking changes.
Someone can just double-check them?