Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update expected code #3480

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix(docs): update expected code #3480

merged 2 commits into from
Feb 14, 2025

Conversation

gforcada
Copy link
Contributor

@gforcada gforcada commented Feb 11, 2025

The example on Generative section names was not the one would expect.

Probably some leftover from a previous refactoring? 🤔

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

The example on Generative section names was not the one would expect.
gaborbernat
gaborbernat previously approved these changes Feb 11, 2025
@gforcada
Copy link
Contributor Author

I see the filename is wrong and that makes CI failing, which filename should I give it? Do I need to create an issue, or reusing the one from this PR is enough?

@gaborbernat
Copy link
Member

You can reuse the one from the PR.

@gaborbernat gaborbernat merged commit 6b40c0c into tox-dev:main Feb 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants