-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print resolved interpreter when using env detection #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we display the resolved environment when --python auto is used Signed-off-by: Stanislav Filin <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Stanislav Filin <[email protected]>
@kemzeb Good evening, Thanks |
Signed-off-by: Stanislav Filin <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Stanislav Filin <[email protected]>
for more information, see https://pre-commit.ci
kemzeb
requested changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine, just a couple of things.
Signed-off-by: Stanislav Filin <[email protected]> Co-authored-by: Kemal Zebari <@kemzeb>
Signed-off-by: Stanislav Filin <[email protected]>
kemzeb
requested changes
Jun 14, 2024
Signed-off-by: Stanislav Filin <[email protected]>
(resolved python: /path/to/interpreter/python3) Signed-off-by: Stanislav Filin <[email protected]> Co-authored-by: Kemal Zebari <@kemzeb>
kemzeb
requested changes
Jun 15, 2024
log_resolved
param to detect_active_interpreter
Start to use ScriptRunner to run --python=auto Signed-off-by: Stanislav Filin <[email protected]>
kemzeb
requested changes
Jun 16, 2024
Co-authored-by: Kemal Zebari <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Stanislav Filin <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Stanislav Filin <[email protected]>
for more information, see https://pre-commit.ci
kemzeb
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good evening,
This is a super quick fix for #372
What I did was create a new param,
log_resolved.
If True, print the resolved Python path.I have only activated this to the
--python auto
option.