Change compression body error type to BoxError
#107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
added
C-enhancement
The compression related middleware would previously use `BodyOrIoError` as the error type. That only implemented `std::error::Error` if the inner error did as well. Since `Box<dyn std::error::Error + Send + Sync>` does not implement `std::error::Error` `Compression` and `Decompression` wouldn't be usable with hyper if the body they wrapped had that error type. This changes the middleware to use `BoxError` as the error type which resolves the issue. Its also consistent with other middleware. Note: This is a breaking change!
davidpdrsn
force-pushed
the
change-compression-error-type
branch
from
44a8608 to
beeb318
Compare
davidpdrsn
added a commit
that referenced
this pull request
Nov 15, 2021
The compression related middleware would previously use `BodyOrIoError` as the body error type. That only implemented `std::error::Error` if the inner error did as well. Since `Box<dyn std::error::Error + Send + Sync>` does not implement `std::error::Error` `Compression` and `Decompression` wouldn't be usable with hyper if the body they wrapped had that error type. This changes the middleware to use `BoxError` as the error type which resolves the issue. Its also consistent with other middleware. Reimplementation of #107 on top of latest `master`.
|
Superseded by #166 |
davidpdrsn
added a commit
that referenced
this pull request
Nov 15, 2021
* Change compression body error type to `BoxError` The compression related middleware would previously use `BodyOrIoError` as the body error type. That only implemented `std::error::Error` if the inner error did as well. Since `Box<dyn std::error::Error + Send + Sync>` does not implement `std::error::Error` `Compression` and `Decompression` wouldn't be usable with hyper if the body they wrapped had that error type. This changes the middleware to use `BoxError` as the error type which resolves the issue. Its also consistent with other middleware. Reimplementation of #107 on top of latest `master`. * changelog * fix doc tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compression related middleware would previously use
BodyOrIoErroras the body error type. That only implemented
std::error::Errorif theinner error did as well. Since
Box<dyn std::error::Error + Send + Sync>does not implement
std::error::ErrorCompressionandDecompressionwouldn't be usable with hyper if the body they wrappedhad that error type.
This changes the middleware to use
BoxErroras the error type whichresolves the issue. Its also consistent with other middleware.
Note: This is a breaking change so should be released in 0.2 when we decide to do that.