Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceBuilderExt #106

Merged
merged 3 commits into from
Nov 18, 2021
Merged

Add ServiceBuilderExt #106

merged 3 commits into from
Nov 18, 2021

Conversation

davidpdrsn
Copy link
Member

Adds ServiceBuilderExt which adds methods to tower::ServiceBuilder
for adding middleware from tower-http. Figured this might be a nice
convenience to have.

Not all middleware are available since they require some specific
configuration. For those I think adding the layer explicitly is better.

@davidpdrsn davidpdrsn added the A-new-util Area: new utility proposals label Jun 4, 2021
@davidpdrsn davidpdrsn added this to the 0.2.0 milestone Nov 8, 2021
Adds `ServiceBuilderExt` which adds methods to `tower::ServiceBuilder`
for adding middleware from tower-http. Figured this might be a nice
convenience to have.
I swear I ran them before pushing 🤔
@davidpdrsn davidpdrsn enabled auto-merge (squash) November 18, 2021 19:53
@davidpdrsn davidpdrsn merged commit eb1d1f1 into master Nov 18, 2021
@davidpdrsn davidpdrsn deleted the service-builder-ext branch November 18, 2021 20:01
@Nehliin
Copy link
Collaborator

Nehliin commented Nov 18, 2021

Nice!

@davidpdrsn davidpdrsn mentioned this pull request Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-new-util Area: new utility proposals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants