Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-query): fix LICENSE.md in @suspensive/react-query to conform MIT license of toss/slash #42

Merged
merged 2 commits into from
May 22, 2023

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented May 20, 2023

fix #37

Fix LICENSE.md in @suspensive/react-query

With this PR(TanStack/query#5259), Documentation of @suspensive/react-query was added to the Community Resources section of TanStack/query's official documentation, and then reverted by @BasixKOR's this PR(TanStack/query#5303)

The reason we discussed was that @suspensive/react-query started from the code of @toss/react-query, but we didn't mark it in LICENSE.md.

so What I followed (@raon0211's guide)

https://gist.github.com/fbaierl/1d740a7925a6e0e608824eb27a429370

@manudeli manudeli requested a review from okinawaa May 20, 2023 05:09
@manudeli manudeli self-assigned this May 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 20, 2023

🦋 Changeset detected

Latest commit: 624835c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@suspensive/react-query Patch
@suspensive/visualization Patch
@suspensive/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 20, 2023 5:10am
graph ⬜️ Ignored (Inspect) Visit Preview May 20, 2023 5:10am
visualization ⬜️ Ignored (Inspect) Visit Preview May 20, 2023 5:10am

@manudeli
Copy link
Member Author

manudeli commented May 20, 2023

@raon0211 @BasixKOR, I followed what you guide about MIT License in our email. Could you check this Pull Request out please?

@okinawaa
Copy link
Member

There was this part.
I checked! I think it'll be okay if we get �two people's confirmation you mentioned

Copy link
Contributor

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Thanks for the heads-up!

Copy link
Contributor

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Thanks for the heads-up!

@okinawaa
Copy link
Member

Thanks to many people, I learned something new. Thank you

@okinawaa okinawaa merged commit 5bc846e into main May 22, 2023
@okinawaa okinawaa deleted the chore/react-query/fix-license branch May 22, 2023 11:19
manudeli added a commit that referenced this pull request Aug 3, 2024
…orm MIT license of toss/slash (#42)

* chore(react-query): fix LICENSE.md in @suspensive/react-query to conform MIT license of toss/slash

* Create brown-actors-sniff.md
manudeli added a commit that referenced this pull request Aug 3, 2024
…orm MIT license of toss/slash (#42)

* chore(react-query): fix LICENSE.md in @suspensive/react-query to conform MIT license of toss/slash

* Create brown-actors-sniff.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Resolve LICENSE problem
3 participants