posix_acl: fix reference leaks in posix_acl_create

get_acl gets a reference which we must release in the error cases. Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Omar Sandoval <[email protected]> Signed-off-by: Al Viro <[email protected]>
torvalds · Feb 20, 2015 · fed0b58 · fed0b58
1 parent 76bf3f6
commit fed0b58
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/fs/posix_acl.c b/fs/posix_acl.c
@@ -564,13 +564,11 @@ posix_acl_create(struct inode *dir, umode_t *mode,
 
 	*acl = posix_acl_clone(p, GFP_NOFS);
 	if (!*acl)
-		return -ENOMEM;
+		goto no_mem;
 
 	ret = posix_acl_create_masq(*acl, mode);
-	if (ret < 0) {
-		posix_acl_release(*acl);
-		return -ENOMEM;
-	}
+	if (ret < 0)
+		goto no_mem_clone;
 
 	if (ret == 0) {
 		posix_acl_release(*acl);
@@ -591,6 +589,12 @@ posix_acl_create(struct inode *dir, umode_t *mode,
 	*default_acl = NULL;
 	*acl = NULL;
 	return 0;
+
+no_mem_clone:
+	posix_acl_release(*acl);
+no_mem:
+	posix_acl_release(p);
+	return -ENOMEM;
 }
 EXPORT_SYMBOL_GPL(posix_acl_create);