Skip to content

Commit

Permalink
net/smsc911x: Add minimal runtime PM support
Browse files Browse the repository at this point in the history
Add minimal runtime PM support (enable on probe, disable on remove), to
ensure proper operation with a parent device that uses runtime PM.

This is needed on systems where the external bus controller module of
the SoC is contained in a PM domain and/or has a gateable functional
clock. In such cases, before accessing any device connected to the
external bus, the PM domain must be powered up, and/or the functional
clock must be enabled, which is typically handled through runtime PM by
the bus controller driver.

An example of this is the kzm9g development board, where an smsc9220
Ethernet controller is connected to the Bus State Controller (BSC) of a
Renesas sh73a0 SoC.

Signed-off-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
geertu authored and davem330 committed Nov 24, 2014
1 parent 4f03721 commit 3a611e2
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions drivers/net/ethernet/smsc/smsc911x.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
#include <linux/of_device.h>
#include <linux/of_gpio.h>
#include <linux/of_net.h>
#include <linux/pm_runtime.h>

#include "smsc911x.h"

#define SMSC_CHIPNAME "smsc911x"
Expand Down Expand Up @@ -2338,6 +2340,9 @@ static int smsc911x_drv_remove(struct platform_device *pdev)

free_netdev(dev);

pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);

return 0;
}

Expand Down Expand Up @@ -2491,6 +2496,9 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
if (pdata->config.shift)
pdata->ops = &shifted_smsc911x_ops;

pm_runtime_enable(&pdev->dev);
pm_runtime_get_sync(&pdev->dev);

retval = smsc911x_init(dev);
if (retval < 0)
goto out_disable_resources;
Expand Down Expand Up @@ -2572,6 +2580,8 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
out_free_irq:
free_irq(dev->irq, dev);
out_disable_resources:
pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);
(void)smsc911x_disable_resources(pdev);
out_enable_resources_fail:
smsc911x_free_resources(pdev);
Expand Down

0 comments on commit 3a611e2

Please sign in to comment.