Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query error when model with o2o pk and m2m field #1783

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

waketzheng
Copy link
Contributor

Description

Fixes #1771

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 12006604964

Details

  • 13 of 14 (92.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 89.511%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/base/schema_generator.py 8 9 88.89%
Totals Coverage Status
Change from base Build 11994314143: 0.002%
Covered Lines: 6244
Relevant Lines: 6867

💛 - Coveralls

tortoise/expressions.py Outdated Show resolved Hide resolved
@waketzheng waketzheng force-pushed the fix-o2o-pk-combine-m2m branch from 011241e to 0395e12 Compare November 25, 2024 04:07
tortoise/models.py Outdated Show resolved Hide resolved
@abondar abondar merged commit 3d18d03 into tortoise:develop Nov 25, 2024
7 checks passed
@waketzheng waketzheng deleted the fix-o2o-pk-combine-m2m branch December 27, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use ManyToManyField if OneToOneField passed as Primary Key
4 participants