Fixed invalid 'var IN ()' SQL generated using '__in=' and '__not_in' …

…filters. (#321)

CHANGELOG.rst

@@ -9,6 +9,10 @@ Changelog
 
 0.16
 ====
+0.16.3
+------
+* Fixed invalid ``var IN ()`` SQL generated using ``__in=`` and ``__not_in`` filters.
+
 0.16.2
 ------
 * Default ``values()`` & ``values_list()`` now includes annotations.

tests/test_filters.py

@@ -34,6 +34,11 @@ async def test_in(self):
             {"moo", "baa"},
         )
 
+    async def test_in_empty(self):
+        self.assertEqual(
+            await CharFields.filter(char__in=[]).values_list("char", flat=True), [],
+        )
+
     async def test_not_in(self):
         self.assertSetEqual(
             set(
@@ -42,6 +47,12 @@ async def test_not_in(self):
             {"oink"},
         )
 
+    async def test_not_in_empty(self):
+        self.assertSetEqual(
+            set(await CharFields.filter(char__not_in=[]).values_list("char", flat=True)),
+            {"oink", "moo", "baa"},
+        )
+
     async def test_isnull(self):
         self.assertSetEqual(
             set(await CharFields.filter(char_null__isnull=True).values_list("char", flat=True)),

tortoise/filters.py

@@ -5,7 +5,7 @@
 from pypika import Table
 from pypika.enums import SqlTypes
 from pypika.functions import Cast, Upper
-from pypika.terms import Criterion, Term
+from pypika.terms import Criterion, Term, ValueWrapper
 
 from tortoise.fields import Field
 from tortoise.fields.relational import BackwardFKRelation, ManyToManyFieldInstance
@@ -45,12 +45,16 @@ def string_encoder(value: Any, instance: "Model", field: Field) -> str:
 ##############################################################################
 
 
-def is_in(field: Term, value: Any) -> Criterion:
-    return field.isin(value)
+def is_in(field: Term, value: Any) -> Term:
+    if value:
+        return field.isin(value)
+    return ValueWrapper(False)
 
 
-def not_in(field: Term, value: Any) -> Criterion:
-    return field.notin(value) | field.isnull()
+def not_in(field: Term, value: Any) -> Term:
+    if value:
+        return field.notin(value) | field.isnull()
+    return ValueWrapper(True)
 
 
 def between_and(field: Term, value: Tuple[Any, Any]) -> Criterion: