located errors: database #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da2ce7
force-pushed
the
database-error-overhall
branch
from
7d613da to
a3549f3
Compare
da2ce7
force-pushed
the
database-error-overhall
branch
3 times, most recently
from
cbc8ad5 to
b695309
Compare
|
This pull request is Ready to Review. |
da2ce7
force-pushed
the
database-error-overhall
branch
from
b695309 to
9a3ba06
Compare
josecelano
approved these changes
Feb 6, 2023
Comment on lines
+44
to
+49
| let details = format!( | ||
| r#" | ||
| status: ´{response_status}´ | ||
| headers: ´{response_headers:?}´ | ||
| text: ´"{response_text}"´"# | ||
| ); |
There was a problem hiding this comment.
hey @da2ce7 , this is an interesting way to have a kind of "object literal" or "anonymous struct". It's related to #172
I would not include it in this PR unless we change all the asserts to follow the same pattern. Maybe the final solution could be a mix of this solution and what I proposed on that PR. In this solution, I still miss the error pointing to the origin line when the condition was not fulfilled.
|
I think this is a very helpful improvement. ack 9a3ba06 |
|
closing in favor of #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #176
Depends #177
This is the first in a series of work to add locations to error messages. I have created the located_error.rs class that gathers location from the error call, and make use of it for the database errors.