Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong req type name in tracker checker output #1038

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Sep 11, 2024

Fix wrong req type name in tracker checker output.

Command:

$ TORRUST_CHECKER_CONFIG='{
    "udp_trackers": ["127.0.0.1:6969"],
    "http_trackers": [],
    "health_checks": []
}' cargo run --bin tracker_checker
   Compiling torrust-tracker v3.0.0-rc.1-develop (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-tracker)
    Finished `dev` profile [optimized + debuginfo] target(s) in 15.42s
     Running `target/debug/tracker_checker`
2024-09-11T09:44:57.432395Z  INFO torrust_tracker::console::clients::checker::service: Running checks for trackers ...

Fixed output:

[
  {
    "Udp": {
      "Ok": {
        "remote_addr": "127.0.0.1:6969",
        "results": [
          [
            "Setup",
            {
              "Ok": null
            }
          ],
          [
            "Connect",
            {
              "Ok": null
            }
          ],
          [
            "Announce",
            {
              "Ok": null
            }
          ],
          [
            "Scrape",
            {
              "Ok": null
            }
          ]
        ]
      }
    }
  }
]

The previous output was:

[
  {
    "Udp": {
      "Ok": {
        "remote_addr": "127.0.0.1:6969",
        "results": [
          [
            "Setup",
            {
              "Ok": null
            }
          ],
          [
            "Connect",
            {
              "Ok": null
            }
          ],
          [
            "Announce",
            {
              "Ok": null
            }
          ],
          [
            "Announce",
            {
              "Ok": null
            }
          ]
        ]
      }
    }
  }
]

Fixed ouoput:

```output
$ TORRUST_CHECKER_CONFIG='{
    "udp_trackers": ["127.0.0.1:6969"],
    "http_trackers": [],
    "health_checks": []
}' cargo run --bin tracker_checker
   Compiling torrust-tracker v3.0.0-rc.1-develop (/home/josecelano/Documents/git/committer/me/github/torrust/torrust-tracker)
    Finished `dev` profile [optimized + debuginfo] target(s) in 15.42s
     Running `target/debug/tracker_checker`
2024-09-11T09:44:57.432395Z  INFO torrust_tracker::console::clients::checker::service: Running checks for trackers ...
[
  {
    "Udp": {
      "Ok": {
        "remote_addr": "127.0.0.1:6969",
        "results": [
          [
            "Setup",
            {
              "Ok": null
            }
          ],
          [
            "Connect",
            {
              "Ok": null
            }
          ],
          [
            "Announce",
            {
              "Ok": null
            }
          ],
          [
            "Scrape",
            {
              "Ok": null
            }
          ]
        ]
      }
    }
  }
]
```
@josecelano josecelano self-assigned this Sep 11, 2024
@josecelano josecelano added Bug Incorrect Behavior - Developer - Torrust Improvement Experience labels Sep 11, 2024
@josecelano josecelano added this to the v3.0.0 milestone Sep 11, 2024
@josecelano
Copy link
Member Author

ACK dbee825

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (e8a0073) to head (dbee825).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1038   +/-   ##
========================================
  Coverage    77.19%   77.19%           
========================================
  Files          178      178           
  Lines        10180    10180           
========================================
  Hits          7858     7858           
  Misses        2322     2322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano merged commit befbe1b into torrust:develop Sep 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Developer - Torrust Improvement Experience Bug Incorrect Behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: the tracker checker result for UDP tracker shows "Announce" for the Scrape test.
1 participant