Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul core Tracker: extract whitelist #1182

Closed
Tracked by #1181
josecelano opened this issue Jan 15, 2025 · 0 comments · Fixed by #1183
Closed
Tracked by #1181

Overhaul core Tracker: extract whitelist #1182

josecelano opened this issue Jan 15, 2025 · 0 comments · Fixed by #1183
Assignees
@josecelano
Labels
Code Cleanup / Refactoring Tidying and Making Neat

Comments

@josecelano
Copy link
Member

Parent issue: #1181
@josecelano josecelano added the Code Cleanup / Refactoring Tidying and Making Neat label Jan 15, 2025
@josecelano josecelano self-assigned this Jan 15, 2025
@josecelano josecelano mentioned this issue Jan 15, 2025
Open
21 tasks
@josecelano josecelano linked a pull request Jan 15, 2025 that will close this issue
Refactor: extract WhitelistManager #1183
Merged
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] move extracted service to new mod
439493d
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] remove unused methods
39d1620
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] extract struct InMemoryWhitelist
ea35ba5
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] extract strcut DatabaseWhitelist
07f53a4
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] move structs to new mods in whitelist
1aa312b
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] move structs to new mods in whitelist
cc2bc7b
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] inject database and whitelist in tracker as dep
2f1abeb 
Inject the database (persistence) and whitelist manager into the Tracker
via the contructor to be able to use the whitelist manager directly in
Axum handlers.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] use WhitelistManager in API handlers
4253d0f 
directly, instead of using it via the Tracker.
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] inject database and whitelist manager in tra…
658d2be 
…cker factory

Refactor in progress. The final goal is to inject the whitelist manager
directly wherever is needed (for example, test evns) to avoid injecting
the whole tracker. Adn to finally remove the whitelist manager from the
Tracker (A higer level refator in progress: remove responsabilities
fromcore Tracker).
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] remove duplicate code
882af33
josecelano added a commit to josecelano/torrust-tracker that referenced this issue Jan 15, 2025
@josecelano
refactor: [torrust#1182] remove whitelist context methods from core t…
57455ca 
…racker
josecelano added a commit that referenced this issue Jan 15, 2025
@josecelano
Merge #1183: Refactor: extract WhitelistManager
b7e009d 
57455ca refactor: [#1182] remove whitelist context methods from core tracker (Jose Celano)
882af33 refactor: [#1182] remove duplicate code (Jose Celano)
658d2be refactor: [#1182] inject database and whitelist manager in tracker factory (Jose Celano)
4253d0f refactor: [#1182] use WhitelistManager in API handlers (Jose Celano)
2f1abeb refactor: [#1182] inject database and whitelist in tracker as dep (Jose Celano)
cc2bc7b refactor: [#1182] move structs to new mods in whitelist (Jose Celano)
07f53a4 refactor: [#1182] extract strcut DatabaseWhitelist (Jose Celano)
ea35ba5 refactor: [#1182] extract struct InMemoryWhitelist (Jose Celano)
39d1620 refactor: [#1182] remove unused methods (Jose Celano)
439493d refactor: [#1182] move extracted service to new mod (Jose Celano)
40eb805 refactor: [1182] extract WhitelistManager (Jose Celano)

Pull request description:

  Refactor: extract `WhitelistManager`

ACKs for top commit:
  josecelano:
    ACK 57455ca

Tree-SHA512: 03fb1b590b8226b96f178b80ce8998955dc70892cba1b9f921138e29cfde5e51df71d3956966338f009b12915b33bbfbb1ff1514c24e8f7868eda402d2918a73
@josecelano josecelano mentioned this issue Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josecelano josecelano

Labels
Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: extract WhitelistManager josecelano/torrust-tracker
1 participant
@josecelano