Configuration overhaul: migrate to Figment crate #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
force-pushed
the
581-configuration-overhaul-migrate-configuration-to-figment
branch
from
c71e4a8 to
d97e86f
Compare
josecelano
force-pushed
the
581-configuration-overhaul-migrate-configuration-to-figment
branch
from
d97e86f to
a068103
Compare
josecelano
force-pushed
the
581-configuration-overhaul-migrate-configuration-to-figment
branch
from
a068103 to
790e1ec
Compare
to the type that has the knowledge.
Use Figment to load settings from toml file and allow overriding settings with env vars.
It was replaced with Figment.
after introducing figment::Jail for testing. It seems Jail changes the current dir and that make other tests fails if they use relative path to load files (in this case fixtures). A solution like useing the env var CARGO_MANIFEST_DIR does not work with `cargo next` when building the container. It only worked when you run the tests with cargo test.
josecelano
force-pushed
the
581-configuration-overhaul-migrate-configuration-to-figment
branch
from
eccfa4b to
757751f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration overhaul: migrate to Figment crate.
Subtasks
TorrustIndextoSettings.Settings.figmentcrate.configcrate.Move config env var constants like(I will do it in a new PR).ENV_VAR_CONFIGfromsrc/bootstraptosrc/configIn a new PR
Use Figment convention for env vars to override tracker API token and auth secret. After this PR is merged, both options will be available (old and new names). We can remove the old ones after replacing all the old env vars in this repo and the Index GUI.
Rename env vars: