-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul tracker keys in torrents and magnet links #494
Overhaul tracker keys in torrents and magnet links #494
Conversation
8cab267
to
10b3670
Compare
It's not easy to test this new behavior because the current test is using the "shared" env which uses a public tracker. I should run a second env with a private tracker but I think that's too complex. I would prefer to test this functionality with unit tests. The problem is the For the time being, I will test manually and remove the E2E test for the personal announce URL. |
10b3670
to
bc509f4
Compare
bc509f4
to
a67c39b
Compare
Tracker HTTP URL: http://localhost:7070 - announce: "http://localhost:7070". - announce_list: "http://localhost:7070" and keeps the original URLs in the uploaded torrent. Tracker UDP URL: udp://localhost:6969 - announce: "udp://localhost:7070". - announce_list: "udp://localhost:7070" and keeps the original URLs in the uploaded torrent. Tracker HTTP URL: http://localhost:7070 - announce: "http://localhost:7070/**KEY**". - announce_list: "http://localhost:7070/**KEY**" and keeps the original URLs in the uploaded torrent. Tracker UDP URL: udp://localhost:6969 - announce: "udp://localhost:7070/**KEY**". - announce_list: "udp://localhost:7070/**KEY**" and keeps the original URLs in the uploaded torrent. It returns an 505 error if it can't get the user's tracker keys. TODO: - The application should not start with close tracker and UDP url in the configuration. - The API should return 503 instead of 500 when it can't connect to the tracker.
…hen user tracker keys can't be generated
a67c39b
to
c1fd866
Compare
…from magnet links
f2bea54
to
d100b5b
Compare
when the Index needs to make a request to the Tracker API and is not available.
…alid For the time being, it only checks that private tracker don't use UDP.
ACK 9b7c5c8 |
Subtasks
Subtasks in the Index GUI