Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist torrent comment #298

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Persist torrent comment #298

merged 7 commits into from
Sep 19, 2023

Conversation

josecelano
Copy link
Member

And add it to the API responses.

  • Torrent details endpoint
  • Torrent list endpoint
  • Include the comment in the downloaded torrent

@josecelano josecelano temporarily deployed to coverage September 18, 2023 14:40 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 18, 2023 14:40 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 18, 2023 14:47 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 18, 2023 14:47 — with GitHub Actions Inactive
@josecelano josecelano linked an issue Sep 18, 2023 that may be closed by this pull request
Store in the database the torrent fields: creation_date, comment, created_by, encoding #296
Closed
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023 •
edited
Loading

Codecov Report

Merging #298 (8821346) into develop (3cf9c44) will increase coverage by 0.04%.
Report is 1 commits behind head on develop.
The diff coverage is 47.84%.

@@             Coverage Diff             @@
##           develop     #298      +/-   ##
===========================================
+ Coverage    43.81%   43.85%   +0.04%     
===========================================
  Files           77       77              
  Lines         4346     4369      +23     
===========================================
+ Hits          1904     1916      +12     
- Misses        2442     2453      +11
Files Changed Coverage Δ
src/databases/mysql.rs 0.00% <0.00%> (ø)
src/models/response.rs 0.00% <0.00%> (ø)
src/models/torrent.rs 18.18% <0.00%> (-0.87%) ⬇️
src/services/torrent.rs 19.87% <0.00%> (ø)
src/databases/database.rs 34.37% <16.66%> (+3.81%) ⬆️
src/databases/sqlite.rs 23.76% <22.22%> (-0.05%) ⬇️
src/models/torrent_file.rs 76.57% <68.83%> (-3.80%) ⬇️
src/services/torrent_file.rs 100.00% <100.00%> (ø)
...s/from_v1_0_0_to_v2_0_0/databases/sqlite_v2_0_0.rs 81.15% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@josecelano josecelano temporarily deployed to coverage September 18, 2023 15:42 — with GitHub Actions Inactive
@josecelano
feat: [#296] persist torrent comment
e9476fc 
and add it to the API responses.

- Torrent details endpoint
- Torrent list endpoint
- Include the comment in the downloaded torrent
@josecelano josecelano temporarily deployed to coverage September 18, 2023 15:43 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 18, 2023 15:43 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 18, 2023 16:19 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 18, 2023 16:19 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 18, 2023 16:53 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 18, 2023 16:53 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 19, 2023 09:45 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 19, 2023 09:45 — with GitHub Actions Inactive
@da2ce7
Copy link
Contributor

da2ce7 commented Sep 19, 2023

fc95453 has a strange commit message...

@josecelano josecelano temporarily deployed to coverage September 19, 2023 11:33 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 19, 2023 11:33 — with GitHub Actions Inactive
@josecelano
refactor: [#296] extract duplicate code
b6fe36b
@josecelano
refactor: [#296] rename vars
1660fd5 
to follow type name.
@josecelano
refator: [#296] move logic to service layer
dfdac19 
The service should know the model but the model should not know the
service. The dependency should be only on one way.
@josecelano
doc: add some comments for BEP 30 implementation
8821346
@josecelano josecelano temporarily deployed to coverage September 19, 2023 11:37 — with GitHub Actions Inactive
@josecelano josecelano temporarily deployed to coverage September 19, 2023 11:37 — with GitHub Actions Inactive
@josecelano
Copy link
Member Author

fc95453 has a strange commit message...

Thank you @da2ce7, Fixed. I do not know how I generated that :-/.

@josecelano josecelano marked this pull request as ready for review September 19, 2023 11:39
@josecelano josecelano requested a review from da2ce7 September 19, 2023 11:39
@josecelano josecelano mentioned this pull request Sep 19, 2023
Closed
2 tasks
@josecelano
Copy link
Member Author

ACK 8821346

@josecelano josecelano removed a link to an issue Sep 19, 2023
Store in the database the torrent fields: creation_date, comment, created_by, encoding #296
Closed
2 tasks
@josecelano josecelano linked an issue Sep 19, 2023 that may be closed by this pull request
Store in the database the torrent field: comment #302
Closed
@josecelano josecelano merged commit ef38ac6 into torrust:develop Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees
No one assigned
Labels
None yet
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store in the database the torrent field: comment
3 participants
@josecelano @codecov-commenter @da2ce7