Merge pull request #50 from torchkge-team/develop

Fixed a wrong assertion error.
torchkge-team · Jul 22, 2019 · 20b44eb · 20b44eb
2 parents 386b955 + a23a62d
commit 20b44eb
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 4 deletions.
diff --git a/setup.cfg b/setup.cfg
@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 0.10.1
+current_version = 0.10.2
 commit = True
 tag = True
 

diff --git a/setup.py b/setup.py
@@ -39,6 +39,6 @@
     test_suite='tests',
     tests_require=test_requirements,
     url='https://github.com/torchkge-team/torchkge',
-    version='0.10.1',
+    version='0.10.2',
     zip_safe=False,
 )
diff --git a/torchkge/__init__.py b/torchkge/__init__.py
@@ -4,7 +4,7 @@
 
 __author__ = """Armand Boschin"""
 __email__ = '[email protected]'
-__version__ = '0.10.1'
+__version__ = '0.10.2'
 
 from .data import KnowledgeGraph
 

diff --git a/torchkge/models/SemanticMatchingModels.py b/torchkge/models/SemanticMatchingModels.py
@@ -611,7 +611,6 @@ def __init__(self, ent_emb_dim, n_entities, n_relations, scalar_share=0.5):
                                 self.ent_emb_dim)
 
         assert (self.real_mask.sum() == self.im_mask.sum() == self.smaller_dim)
-        assert (self.scalar_mask.sum() == self.real_mask.sum() * 2)
 
     def compute_product(self, heads, tails, rel_mat):
         """Compute the matrix product h^tRt with proper reshapes. It can do the batch matrix

diff --git a/torchkge/sampling/__init__.py b/torchkge/sampling/__init__.py
@@ -1,2 +1,3 @@
 from .NegativeSampling import PositionalNegativeSampler
 from .NegativeSampling import BernoulliNegativeSampler
+from .NegativeSampling import UniformNegativeSampler