Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing template errors #365

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

shyusu4
Copy link
Collaborator

@shyusu4 shyusu4 commented Feb 12, 2025

Description of Changes Made

Fixing errors on staging:

  • 'TemplateDoesNotExist', replaced the old motif heading template with new the new motif-heading class implementation
  • 'Unclosed tag on line 3: 'if'. Looking for one of: elif, else, endif.', added the missing class in the work_chooser_block.html

How to Test

Check the styleguide http://0.0.0.0:8000/pattern-library/render-pattern/patterns/styleguide/typography/typography.html or any relevant component

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@shyusu4 shyusu4 requested a review from SharmaineLim February 12, 2025 10:28
@shyusu4 shyusu4 changed the title Replace old motif heading template with new class Fixing template errors Feb 12, 2025
@shyusu4
Copy link
Collaborator Author

shyusu4 commented Feb 12, 2025

@SharmaineLim I'll go ahead and merge this in

@shyusu4 shyusu4 merged commit ff886c8 into integration/2024-evolution Feb 12, 2025
4 checks passed
@shyusu4 shyusu4 deleted the fix/replace-old-motif-template branch February 12, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants