Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promo block be #124

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Promo block be #124

merged 4 commits into from
Feb 27, 2024

Conversation

KIRA009
Copy link
Collaborator

@KIRA009 KIRA009 commented Feb 26, 2024

Link to Ticket

Description of Changes Made

Added a promo block to the story blocks of Home Page and Service Page

How to Test

  • Navigate to any existing/Create a new HomePage/ServicePage page
  • Verify that the body streamfield of both page types have the new Promo block
  • Verify that the secondary link is optional, and the preview consists of the correct links and button texts

Screenshots

Editor view image

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

  • Automated WCAG 2.1 tests pass
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@KIRA009 KIRA009 requested a review from lparsons396 February 26, 2024 10:34
@lparsons396 lparsons396 force-pushed the feature/2824-homepage-be branch from 1c5465e to 7a8fb3f Compare February 26, 2024 10:48
Base automatically changed from feature/2824-homepage-be to integration/sprint-4 February 26, 2024 10:58
@KIRA009 KIRA009 force-pushed the feature/5445-promo-block-be branch from c51bf79 to 23c6ce8 Compare February 26, 2024 11:14
@helenb helenb requested review from nimasmi and ianmeigh and removed request for lparsons396 February 26, 2024 11:19
@KIRA009 KIRA009 force-pushed the feature/5445-promo-block-be branch from 23c6ce8 to 74d12aa Compare February 26, 2024 11:30
Copy link

@nimasmi nimasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I have comments, but they're all about code and structure, and none about functionality or UX, so take them as you please.

tbx/core/blocks.py Show resolved Hide resolved
tbx/core/blocks.py Show resolved Hide resolved
Copy link
Collaborator

@ianmeigh ianmeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

required=True,
max_num=1,
)
secondary_link = LinkBlock(required=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: this is appearing in the editor just as 'Link' - could it say 'Secondary link' to be clearer for editors?
Screenshot 2024-02-26 at 16 01 14

@KIRA009 KIRA009 force-pushed the feature/5445-promo-block-be branch 3 times, most recently from 18b5266 to 0d65a34 Compare February 27, 2024 09:41
@KIRA009 KIRA009 force-pushed the feature/5445-promo-block-be branch from 0d65a34 to 9bcf870 Compare February 27, 2024 10:26
@KIRA009 KIRA009 merged commit 70ffadd into integration/sprint-4 Feb 27, 2024
4 checks passed
@KIRA009 KIRA009 deleted the feature/5445-promo-block-be branch February 27, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants