Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go 1.19 to fix ci #177

Merged
merged 1 commit into from
Feb 8, 2023
Merged

update go 1.19 to fix ci #177

merged 1 commit into from
Feb 8, 2023

Conversation

llamerada-jp
Copy link
Contributor

By the error message below, go 1.19 looks to be required by some packages. And k8s 1.23, ~ 1.25 use go 1.19. So I try to update go 1.19.

https://github.com/topolvm/pvc-autoresizer/actions/runs/4081279918/jobs/7072721083

# honnef.co/go/tools/unused
Error: ../../../go/pkg/mod/honnef.co/go/[email protected]/unused/unused.go:4[19](https://github.com/topolvm/pvc-autoresizer/actions/runs/4081279918/jobs/7072721083#step:7:20):14: obj.Origin undefined (type *types.Var has no field or method Origin)
Error: ../../../go/pkg/mod/honnef.co/go/[email protected]/unused/unused.go:4[21](https://github.com/topolvm/pvc-autoresizer/actions/runs/4081279918/jobs/7072721083#step:7:22):14: obj.Origin undefined (type *types.Func has no field or method Origin)
note: module requires Go 1.19

Signed-off-by: Yuji Ito [email protected]

@llamerada-jp llamerada-jp requested a review from a team as a code owner February 8, 2023 02:39
@llamerada-jp llamerada-jp requested review from pluser and cupnes February 8, 2023 02:39
@llamerada-jp llamerada-jp changed the title try to update go 1.19 to fix ci update go 1.19 to fix ci Feb 8, 2023
@llamerada-jp llamerada-jp merged commit faed0f0 into main Feb 8, 2023
@llamerada-jp llamerada-jp deleted the update-go branch February 8, 2023 02:57
@toshipp toshipp mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluser pluser pluser approved these changes

@cupnes cupnes cupnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llamerada-jp @pluser @cupnes