Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system updates for Nobara #661

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

thecatcore
Copy link
Contributor

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Description

Nobara has some repositories that aren't updated by the default dnf distro-sync --refresh.
I've implemented the workaround indicated at Nobara Project.

@SteveLauC
Copy link
Member

Hi, thanks for this patch!

What will happen if you simply run nobara-sync in your terminal? Will it only launch the Update System app, and thus you still need to click the update button yourself?

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Generally, I think we should follow the document, and use the suggested commands to do the update:

$ sudo dnf update rpmfusion-nonfree-release rpmfusion-free-release fedora-repos nobara-repos --refresh 
$ sudo dnf distro-sync --refresh 
$ sudo dnf update --refresh

though a -y option is needed is assume_yes is set to true.

@thecatcore
Copy link
Contributor Author

Hi, thanks for this patch!

What will happen if you simply run nobara-sync in your terminal? Will it only launch the Update System app, and thus you still need to click the update button yourself?

Yes that is exactly what is happening, it opens the graphical app.

@thecatcore
Copy link
Contributor Author

Thanks for the PR!

Generally, I think we should follow the document, and use the suggested commands to do the update:

$ sudo dnf update rpmfusion-nonfree-release rpmfusion-free-release fedora-repos nobara-repos --refresh 
$ sudo dnf distro-sync --refresh 
$ sudo dnf update --refresh

though a -y option is needed is assume_yes is set to true.

I agree with you, but using --refresh 3 times and update 2 times seems redundant, I've tested my implementation and it seems to be enough on my end so far.

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC SteveLauC merged commit 3ed763b into topgrade-rs:main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants